Open
Conversation
segun
commented
Nov 22, 2023
Collaborator
|
@segun : Can you plz test the PR in extension to ensure that validation works on multiple chains, additionally caching data files and switching between networks should work well. |
|
@segun would you mind also including Linea on this PR? - we have been unblocked for supporting this network too and are good to go |
13 tasks
segun
force-pushed
the
olu/send-ppom-on-more-networks
branch
3 times, most recently
from
d39226b to
c399d94
Compare
segun
commented
Dec 6, 2023
| callBack({ providerConfig: { chainId: '0x6' } }); | ||
|
|
||
| expect(Object.keys(ppomController.state.chainStatus)).toHaveLength(5); | ||
| jest.useFakeTimers().setSystemTime(new Date('2023-01-04')); |
Contributor
Author
There was a problem hiding this comment.
I needed to add one more because the condition in ppomController for this check to happen is > 5. It doesn't do the check if its <= 5
segun
force-pushed
the
olu/send-ppom-on-more-networks
branch
from
c399d94 to
2cf1cdd
Compare
segun
commented
Dec 6, 2023
| chainStatus[chainId]?.versionInfo ?? | ||
| this.state.versionInfo.filter(({ chainId: id }) => id === chainId); | ||
| console.log('chainStatus 1008', chainStatus); | ||
| const hasVersionInfo = chainStatus[chainId]?.versionInfo?.length; |
Contributor
Author
There was a problem hiding this comment.
I noticed this part wasn't been called in tests because chainStatus[chainId]?.versionInfo is usually [] not undefined/null. So this check makes sure it works either it's undefined, null or []
digiwand
reviewed
Dec 6, 2023
digiwand
previously approved these changes
Dec 6, 2023
Ethereum Mainnet (already done) BNB chain Polygon Arbitrum Optimism Avalanche Test case for supported chain id Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add linea mainnet to supported chain IDs. Lint fixes Fix tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
segun
force-pushed
the
olu/send-ppom-on-more-networks
branch
from
33e1943 to
4976b8c
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should enabled PPOM on the following networks:
Ethereum Mainnet (already done)
BNB chain
Polygon
Arbitrum
Optimism
Avalanche
Linea
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1693